[PATCH v3 1/5] ARM: protect usage of cr_alignment by #ifdef CONFIG_CPU_CP15

Uwe Kleine-König u.kleine-koenig at pengutronix.de
Wed Mar 14 17:53:44 EDT 2012


Hello Nicolas,

On Wed, Mar 14, 2012 at 05:19:53PM -0400, Nicolas Pitre wrote:
> On Wed, 14 Mar 2012, Uwe Kleine-König wrote:
> > On Wed, Mar 14, 2012 at 11:24:36AM -0400, Nicolas Pitre wrote:
> > > >  	flush_cache_all();
> > > > +#ifdef CONFIG_CPU_CP15
> > > >  	set_cr(cr_alignment);
> > > > +#endif
> > > 
> > > However it might be best to provide a dummy set_cr() instead of 
> > > #ifdef'ing it out everywhere.
> > What should the dummy set_cr do? Print a runtime warning if called with
> > != 0?
> 
> Maybe not.  In fact if that code path is used, then something might be 
> wrong at a higher level.
And that's why I choosed not to implement a dummy set_cr ...

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |



More information about the linux-arm-kernel mailing list