On 03/14/2012 04:56 PM, Thierry Reding wrote: > [...] > +struct pwm_chip { > + int pwm_id; > + const char *label; > + struct pwm_ops *ops; Nothing major, but if you are going for another round it would be good to see ops made const. > +};