[PATCH v3 2/5] ARM: Add a printk loglevel modifier

Arnd Bergmann arnd at arndb.de
Wed Mar 14 09:12:51 EDT 2012


On Wednesday 14 March 2012, Uwe Kleine-König wrote:
> This is a needed followup for
> 
>         ARM: protect usage of cr_alignment by #ifdef CONFIG_CPU_CP15
> 
> otherwise no newline is printed for !CONFIG_CPU_CP15
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig at pengutronix.de>
> ---
> Should this be folded into the
> 
>         ARM: protect usage of cr_alignment by #ifdef CONFIG_CPU_CP15
> 
> patch? Or should it come before it?
> 

I think this patch needs a better explanation. It looks to me that
it's simply a bug fix, because every printk that is not a continuation
of a previous printk needs a KERN_* line. In that case, it should
just get applied as a bug fix independent of the other patches.

However, if you sometimes don't have a newline after the previous
printk, this patch is actually wrong and should not get applied at
all.

	Arnd



More information about the linux-arm-kernel mailing list