[PATCH 1/3] ARM: OMAP2+: 32k-counter: Use hwmod lookup to check presence of 32k timer
Ming Lei
tom.leiming at gmail.com
Tue Mar 13 07:37:16 EDT 2012
Hi,
On Tue, Jan 24, 2012 at 7:38 AM, Kevin Hilman <khilman at ti.com> wrote:
> Vaibhav Hiremath <hvaibhav at ti.com> writes:
>
>> OMAP device has 32k-sync timer which is currently used as a
>> clocksource in the kernel (omap2plus_defconfig).
>> The current implementation uses compile time selection between
>> gp-timer and 32k-sync timer, which breaks multi-omap build for
>> the devices like AM33xx, where 32k-sync timer is not available.
>>
>> So use hwmod database lookup mechanism, through which at run-time
>> we can identify availability of 32k-sync timer on the device,
>> else fall back to gp-timer.
>
> With the runtime detection & fallback, I suggest also removing the
> Kconfig choice between the two as well.
IMO, under some situations, gp timer clocksource has high precision
and is very useful, so hope the Kconfig choice can be kept, or using
kernel parameter way, and the patch need to be changed to support the
selection.
thanks,
--
Ming Lei
More information about the linux-arm-kernel
mailing list