[PATCH v4 2/2] ARM: Exynos: Add device tree support for interrupt combiner

Thomas Abraham thomas.abraham at linaro.org
Tue Mar 13 02:46:17 EDT 2012


On 13 March 2012 09:22, Grant Likely <grant.likely at secretlab.ca> wrote:
> On Tue, 21 Feb 2012 10:03:26 +0530, Thomas Abraham <thomas.abraham at linaro.org> wrote:
>> Add device tree based instantiation of the interrupt combiner controller.
>>
>> Cc: Grant Likely <grant.likely at secretlab.ca>
>> Cc: Rob Herring <rob.herring at calxeda.com>
>> Signed-off-by: Thomas Abraham <thomas.abraham at linaro.org>
>> ---
>> @@ -406,13 +432,33 @@ void __init combiner_init(void __iomem *combiner_base, struct device_node *np)
>>
>>       for (i = 0; i < MAX_COMBINER_NR; i++) {
>>               combiner_init_one(i, combiner_base + (i >> 2) * 0x10);
>> -             combiner_cascade_irq(i, IRQ_SPI(i));
>> +#ifdef CONFIG_OF
>> +             irq = np ? irq_of_parse_and_map(np, i) : IRQ_SPI(i);
>> +#else
>> +             irq = IRQ_SPI(i);
>> +#endif
>
> Hmmm, the #ifdef is rather ugly.  I'd rather have an empty
> irq_of_parse_and_map() that always returns 0.
>
> The patch series is fine, and you can add my acked-by, but please send
> a follow-up patch to clean it up.
>
> Acked-by: Grant Likely <grant.likely at secretlab.ca>
>

Thanks. I will send a follow-up to clean it.

Regards,
Thomas.



More information about the linux-arm-kernel mailing list