[PATCH RESEND v3 1/2] GPIO: LPC32xx: Fix missing bit selection mask

Grant Likely grant.likely at secretlab.ca
Mon Mar 12 12:38:38 EDT 2012


On Mon,  5 Mar 2012 23:01:10 +0100, Roland Stigge <stigge at antcom.de> wrote:
> Add missing mask to pin bit selection in gpio-lpc32xx.c
> (#define GPIO3_PIN_IN_SEL)
> 
> Signed-off-by: Roland Stigge <stigge at antcom.de>
> Acked-by: Arnd Bergmann <arnd at arndb.de>

Applied, thx.

g.

> 
> ---
>  drivers/gpio/gpio-lpc32xx.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2.6.orig/drivers/gpio/gpio-lpc32xx.c
> +++ linux-2.6/drivers/gpio/gpio-lpc32xx.c
> @@ -59,7 +59,7 @@
>  #define GPO3_PIN_TO_BIT(x)			(1 << (x))
>  #define GPIO012_PIN_IN_SEL(x, y)		(((x) >> (y)) & 1)
>  #define GPIO3_PIN_IN_SHIFT(x)			((x) == 5 ? 24 : 10 + (x))
> -#define GPIO3_PIN_IN_SEL(x, y)			((x) >> GPIO3_PIN_IN_SHIFT(y))
> +#define GPIO3_PIN_IN_SEL(x, y)			(((x) >> GPIO3_PIN_IN_SHIFT(y)) & 1)
>  #define GPIO3_PIN5_IN_SEL(x)			(((x) >> 24) & 1)
>  #define GPI3_PIN_IN_SEL(x, y)			(((x) >> (y)) & 1)
>  
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.



More information about the linux-arm-kernel mailing list