[PATCH v3 02/13] gpio/omap: fix wakeup_en register update in _set_gpio_wakeup()

Santosh Shilimkar santosh.shilimkar at ti.com
Wed Mar 7 06:59:18 EST 2012


On Wednesday 07 March 2012 12:15 PM, Tarun Kanti DebBarma wrote:
> There are two ways through which wakeup_en register can be programmed
> using gpiolib APIs as shown below. It is seen that in the second case
> in _set_gpio_wakeup(), even though bank->suspend_wakeup is updated
> correctly, its value is not programmed in wakeup_en register. Fix this.
> 
> chip.irq_set_type()->gpio_irq_type()->_set_gpio_triggering()->set_gpio_trigger()
> chip.irq_set_wake()->gpio_wake_enable()->_set_gpio_wakeup()
> 
> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti at ti.com>
> ---
Looks good.
Reviewed-by: Santosh Shilimkar <santosh.shilimkar at ti.com>

Regards
Santosh



More information about the linux-arm-kernel mailing list