[PATCH v3 11/13] gpio/omap: fix dataout register overwrite in _set_gpio_dataout_*
Tarun Kanti DebBarma
tarun.kanti at ti.com
Wed Mar 7 06:16:01 EST 2012
In the existing _set_gpio_dataout_*() implementation, the dataout
register is overwritten every time the function is called. This is
not intended behavior because that would end up one user of a GPIO
line overwriting what is written by another. Fix this so that previous
value is always preserved until explicitly changed by respective
user/driver of the GPIO line.
Signed-off-by: Tarun Kanti DebBarma <tarun.kanti at ti.com>
---
drivers/gpio/gpio-omap.c | 3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
index 04c2677..2e8e476 100644
--- a/drivers/gpio/gpio-omap.c
+++ b/drivers/gpio/gpio-omap.c
@@ -114,6 +114,7 @@ static void _set_gpio_dataout_reg(struct gpio_bank *bank, int gpio, int enable)
else
reg += bank->regs->clr_dataout;
+ l |= __raw_readl(bank->base + bank->regs->set_dataout);
__raw_writel(l, reg);
bank->context.dataout = l;
}
@@ -130,6 +131,8 @@ static void _set_gpio_dataout_mask(struct gpio_bank *bank, int gpio, int enable)
l |= gpio_bit;
else
l &= ~gpio_bit;
+
+ l |= __raw_readl(bank->base + bank->regs->set_dataout);
__raw_writel(l, reg);
bank->context.dataout = l;
}
--
1.7.0.4
More information about the linux-arm-kernel
mailing list