[PULL REQUEST v2] ARM: kirkwood: fdt: convert kirkwood init funcs to fdt
Jason
jason at lakedaemon.net
Mon Mar 5 15:29:41 EST 2012
On Mon, Mar 05, 2012 at 08:16:26PM +0000, Arnd Bergmann wrote:
> On Monday 05 March 2012, Jason wrote:
> > >
> > > The clock frequency part being hardcoded to 200000 in the common .dtsi
> > > file looks wrong. The clock may differ, and it used to (and should) be
> > > probed at run time, please see kirkwood_find_tclk().
> >
> > So, should I EXPORT_SYMBOL_GPL(kirkwood_find_tclk); and have each driver
> > call it?
>
> If the drivers want to use it, I think it has to be orion_find_tclk for
> drivers that are shared between multiple plat-orion platforms.
That's pretty much all of them :-)
I'll rename it and move it to plat-orion/common.c. This'll be fun.
> > One alternate idea I had was to have kirkwood-dreamplug.dts root hold
> >
> > tclk: clock-frequency = <200000000>;
> >
> > and then have the drivers ask for it. afaict, tclk is constant per
> > board.
> >
> > I'm fine with either way, but I'd rather have it in the dt.
>
> IMHO it's best to leave any such hacks out of the device tree for
> now, until we have the proper clk bindings in place for kirkwood,
> and then we can just use those.
Ok.
thx,
Jason.
More information about the linux-arm-kernel
mailing list