[PATCH] omap3_beagle: Init only uart3 used for console

Kevin Hilman khilman at ti.com
Mon Mar 5 15:00:16 EST 2012


"Govindraj.R" <govindraj.raja at ti.com> writes:

> From: "Govindraj.R" <govindraj.raja at ti.com>
>
> On beagle some of uart mux lines are used for other
> purpose so init only uart3.

OK, but you should also be clear that this patch is effectively
disabling all UARTS (except UART3) by defatul, which I'm not sure all
Beagle users will be happy about.

> Uart2 rx line clashes with gpio_147 used for usb ehci
> phy reset. Initializing uart2 pad_mux lines can break
> ehci module on beagle xm.
> (gpio_147 is available on uart2_rx in mode4 reference 
> mux34xx.c -> uart2_rx.gpio_147)

As Koen mentioned, this conflict only exists on certain boards, so
you should be clear that this is just an example.

> Cc: Tony Lindgren <tony at atomide.com>
> Cc: Kevin Hilman <khilman at ti.com>
> Tested-by: Peter Ujfalusi <peter.ujfalusi at ti.com>
> Tested-by: Robert Nelson <robertcnelson at gmail.com>
> Signed-off-by: Govindraj.R <govindraj.raja at ti.com>

[...]

> +
> +static inline void board_serial_init(void)

Should be __init

[...]

> +static inline void board_serial_init(void)

here too.

Kevin



More information about the linux-arm-kernel mailing list