[PATCH] ARM: OMAP2+: voltage: ensure voltage used is exact voltage from OPP table
Kevin Hilman
khilman at ti.com
Mon Mar 5 13:12:15 EST 2012
Tero Kristo <t-kristo at ti.com> writes:
> On Fri, 2012-03-02 at 14:42 -0800, Kevin Hilman wrote:
>> When using the SMPS regulators to scale voltages, the regulator
>> framework may pass a minimum voltage that is not an exact OPP voltage.
>> For the VC/VP controlled voltage domains, we must ensure that the
>> voltage requested is the exact voltage from the OPP table. This is
>> especially critical when using SR.
>>
>> To fix, voltdm_scale() uses the target voltage passed to walk through
>> the OPP voltages until it finds a voltage that is >= one of the OPP
>> voltages.
>
> I have just one question to this, how about smartreflex class1p5? Do we
> have any plans for that one? The old implementation at least was using
> voltdm_scale, so if we modify this function, smartreflex class1p5
> doesn't work anymore.
Since it's not in mainline, that is not my concern at the moment. We
can worry about SR1.5 when I someone is motivated to push it upstream.
> Otherwise this patch looks good to me.
Thanks for looking.
Kevin
More information about the linux-arm-kernel
mailing list