[PATCH v4 4/4] memory: emif: add device tree support to emif driver

[Shilimkar, Santosh]

On Sat, Jun 30, 2012 at 9:53 AM, Greg KH <gregkh at linuxfoundation.org> wrote:
> On Sat, Jun 30, 2012 at 09:38:41AM +0530, Shilimkar, Santosh wrote:
>> (+ Greg, By mistake the your name got dropped cc from list)
>>
>> On Fri, Jun 29, 2012 at 7:13 PM, Santosh Shilimkar
>> <santosh.shilimkar at ti.com> wrote:
>> > From: Aneesh V <aneesh at ti.com>
>> >
>> > Device tree support for the EMIF driver.
>> >
>> > Reviewed-by: Benoit Cousson <b-cousson at ti.com>
>> > Reviewed-by: Grant Likely <grant.likely at secretlab.ca>
>> > Tested-by: Lokesh Vutla <lokeshvutla at ti.com>
>> > Signed-off-by: Aneesh V <aneesh at ti.com>
>> > [santosh.shilimkar at ti.com: Rebased against 3.5-rc]
>> > Signed-off-by: Santosh Shilimkar <santosh.shilimkar at ti.com>
>> > ---
>> >  drivers/memory/emif.c |  291 ++++++++++++++++++++++++++++++++++++++++++++++++-
>> >  1 file changed, 290 insertions(+), 1 deletion(-)
>
> Wouldn't this just be better off as a separate file that only gets build
> if CONFIG_OF is set, as I'm sure that other systems are going to want
> access to these "read the device tree values" functions, right?
>
Probably yes. At least separate the LPDDR2 memory
generic parameter DT read code. There are parameters like phy
type which is specific to OMAP controllers so that still need to kept
inside EMIF driver. So there in driver, few lines of code will be there
under CONFIG_OF.

I can extract those functions which can be commonly used and put them
in another file under drivers/memory/

Is that fine with you ?

Regards
Santosh