[PATCH v2 3/3] ARM: omap: clk: Remove all direct dereferencing of struct clk

Paul Walmsley paul at pwsan.com
Fri Jun 29 16:23:34 EDT 2012


On Wed, 27 Jun 2012, Rajendra Nayak wrote:

> While we move to Common Clk Framework (CCF), direct deferencing of struct
> clk wouldn't be possible anymore. Hence get rid of all such instances
> in the current clock code and use macros/helpers similar to the ones that
> are provided by CCF.
> Signed-off-by: Rajendra Nayak <rnayak at ti.com>

This patch generates checkpatch warnings.  Here's a sample:

WARNING: quoted string split across lines
#479: FILE: arch/arm/mach-omap2/clock.c:109:
 		pr_debug("clock: could not associate clk %s to "
+			 "clkdm %s\n", clk_name, clk->clkdm_name);

CHECK: Alignment should match open parenthesis
#594: FILE: arch/arm/mach-omap2/dpll3xxx.c:455:
+	if (__clk_get_rate(dd->clk_bypass) == rate &&
 	    (clk->dpll_data->modes & (1 << DPLL_LOW_POWER_BYPASS))) {

ERROR: Macros with complex values should be enclosed in parenthesis
#706: FILE: arch/arm/plat-omap/include/plat/clock.h:22:
+#define __clk_get_name(clk) clk->name

In the case of the quoted string warnings, please go ahead and
concatenate those strings while you are there.  That needs to be done

- Paul

More information about the linux-arm-kernel mailing list