[PATCH 1/3] mfd: support 88pm80x in 80x driver

Arnd Bergmann arnd at arndb.de
Thu Jun 28 10:32:23 EDT 2012


On Thursday 28 June 2012, Mark Brown wrote:
> Show Details
>   On Thu, Jun 28, 2012 at 11:21:56AM +0000, Arnd Bergmann wrote:
> 
> > What platform is this driver for?
> >  - If it's for an existing platform that does not have DT support, please
> >    include the platform changes for that platform so we can see what gets
> >    done in there.
> 
> This is really not normal practice for device drivers, it'd be a serious
> obstacle to getting drivers integrated if we have to have a board merged
> with every driver.

But it would be very helpful to see how the platform data is set, especially
with the callback. If the callback is just there to set up a regulator
or clock, then it should be changed to a more generic way.

	Arnd



More information about the linux-arm-kernel mailing list