[PATCH v11 3/4] MTD: nand: add return value for write_page()/write_page_raw() functions in structure of nand_ecc_ctrl.
dedekind1 at gmail.com
Wed Jun 27 05:26:36 EDT 2012
On Mon, 2012-06-25 at 18:07 +0800, Josh Wu wrote:
> There is an implemention of hardware ECC write page function which may return an
> error indication.
> For instance, using Atmel HW PMECC to write one page into a nand flash, the hardware
> engine will compute the BCH ecc code for this page. so we need read a the
> status register to theck whether the ecc code is generated.
> But we cannot assume the status register always can be ready, for example,
> incorrect hardware configuration or hardware issue, in such case we need
> write_page() to return a error code.
> Since the definition of 'write_page' function in struct nand_ecc_ctrl is 'void'.
> So this patch will:
> 1. add return 'int' value for 'write_page' function.
> 2. to be consitent, add return 'int' value for 'write_page_raw' fuctions too.
> 3. add code to test the return value, and if negative, indicate an
> error happend when write page with ECC.
> 4. fix the compile warning in all impacted nand flash driver.
> Note: I couldn't compile-test all of these easily, as some had ARCH dependencies.
> Signed-off-by: Josh Wu <josh.wu at atmel.com>
Pushed this patch to l2-mtd.git, thanks!
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: This is a digitally signed message part
More information about the linux-arm-kernel