[PATCH] MXS: Enable FLEXCAN for MXS/DT

Marc Kleine-Budde mkl at pengutronix.de
Tue Jun 26 07:43:11 EDT 2012


On 06/26/2012 01:28 PM, Shawn Guo wrote:
> On Tue, Jun 26, 2012 at 11:07:24AM +0200, Marc Kleine-Budde wrote:
>>> +       select HAVE_CAN_FLEXCAN if NET && CAN
>>
>> ...and put this select to MACH_MXS_DT, instead of SOC_IMX28
>>
> Hmm, why?  Flexcan is a feature/block of SoC rather than a machine,
> isn't it?

Yes, but the HAVE_CAN_FLEXCAN is used to make the driver available in
Kconfig. What about removing the "depends on HAVE_CAN_FLEXCAN" from the
driver symbol in Kconfig? I can push it via net-next and it will be
mainline in 3.6. You can remove the HAVE_CAN_FLEXCAN from the ARM (and
powerpc) trees.

To avoid Kconfig hickups I'll keep the HAVE_CAN_FLEXCAN symbol in the
net-tree as long as the select HAVE_CAN_FLEXCAN is still present.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 262 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120626/e1a388a0/attachment.sig>


More information about the linux-arm-kernel mailing list