[PATCH v4 3/9] arm: mach-mvebu: add source files

Andrew Lunn andrew at lunn.ch
Tue Jun 26 06:21:20 EDT 2012


On Tue, Jun 26, 2012 at 12:05:53PM +0200, Gregory CLEMENT wrote:
> On 06/26/2012 10:47 AM, Andrew Lunn wrote:>> +#define ARMADA_370_XP_RESET_OFFSET		  0x60
> >> +#define OTHER_MVEBU_RESET_OFFSET		 0x108
> >> +#define MVEBU_RSTOUTN_MASK_OFFSET		   0x0
> >> +#define   OTHER_MVEBU_RSTOUTN_MASK_RESET_OUT_EN	   0x4
> >> +#define   ARMADA_370_XP_RSTOUTN_MASK_RESET_OUT_EN  0x1
> >> +#define MVEBU_SYSTEM_SOFT_RESET_OFFSET		   0x4
> >> +#define   MVEBU_SYSTEM_SOFT_RESET		   0x1
> >> +
> >> +#define OTHER_MVEBU_VARIANT	1
> >> +#define ARMADA_370_XP_VARIANT	2
> >
> > Hi Gregory
> >
> 
> Hi Andrew,
> 
> > Rather than OTHER, could you call this ORION?
> >
> 
> I thought that one purpose of the next mach-mvebu directory, was to
> remove the references to orion.
> 
> However, I agree that OTHER is not a really good name. We could
> consider indeed 'orion' as a legacy name for this subset of' mvebu'.

Well, Orion is well known to describe this subset. If we want to
remove the use of Orion we need a different naming scheme. We could
use V1 for Orion, and V2 for ARMADA 370 XP. 

For me, using orion and armada-370-xp is more informative.

    Andrew



More information about the linux-arm-kernel mailing list