[PATCH v4] ARM: mx23: Add initial support for olinuxino board

[Fabio Estevam]

Hi Shawn,

On Mon, Jun 25, 2012 at 1:05 PM, Shawn Guo <shawn.guo at linaro.org> wrote:
> On Mon, Jun 18, 2012 at 10:51:52AM -0300, Fabio Estevam wrote:
>> +
>> +                             mmc0_4bit_pins_a: mmc0-4bit at 0 {
>> +                                     reg = <0>;
>> +                                     fsl,pinmux-ids = <0x2000 0x2020 0x2030
>> +                                             0x2040 0x2050>;
>> +                                     fsl,drive-strength = <1>;
>> +                                     fsl,voltage = <1>;
>> +                                     fsl,pull-up = <1>;
>> +                             };
>> +
>> +                             mmc0_sck_cfg: mmc0_sck_cfg {
>> +                                     fsl,pinmux-ids = <0x2010>;
>> +                                     fsl,pull-up = <0>;
>> +                             };
>
> This looks suspicious.  First of all, 0x2010 (SSP1_DETECT) should be
> in pinmux-ids of mmc0_4bit_pins_a.  Secondly, SSP1_SCK seems missing
> from the pins.  You do not have a SSP1_SCK pin for the mmc slot?

Looks like the ROM code did the IOMUX setup of SSP1_SCK, so that's why
it worked.

I will fix it. How do you want me to handle it? Via an incremental
patch against your tree or should I post a new version of the patch?

Regards,

Fabio Estevam