[PATCH 06/11] gpio/omap: add clk_prepare and clk_unprepare

[Paul Walmsley]

Hi

On Fri, 22 Jun 2012, Rajendra Nayak wrote:

> In preparation of OMAP moving to Common Clk Framework(CCF) add clk_prepare()
> for omap gpio debounce clock.
> 
> Signed-off-by: Rajendra Nayak <rnayak at ti.com>
> Cc: Grant Likely <grant.likely at secretlab.ca>
> ---
>  drivers/gpio/gpio-omap.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c
> index c4ed172..6a73b01 100644
> --- a/drivers/gpio/gpio-omap.c
> +++ b/drivers/gpio/gpio-omap.c
> @@ -893,6 +893,8 @@ static int gpio_debounce(struct gpio_chip *chip, unsigned offset,
>  		bank->dbck = clk_get(bank->dev, "dbclk");
>  		if (IS_ERR(bank->dbck))
>  			dev_err(bank->dev, "Could not get gpio dbck\n");
> +		else
> +			clk_prepare(bank->dbck);
>  	}
>  
>  	spin_lock_irqsave(&bank->lock, flags);

What code unprepares this clock?

Put differently, doesn't this driver need at least a platform_driver 
.remove function pointer, that would call clk_unprepare() and clk_put()?

Also, it looks to me that the bank->dbck init should be in 
omap_gpio_chip_init(), not gpio_debounce()?


- Paul