[PATCH v3 3/4] dt: add clock binding doc to primecell bindings

Russell King - ARM Linux linux at arm.linux.org.uk
Fri Jun 22 10:23:17 EDT 2012

On Fri, Jun 22, 2012 at 02:55:52PM +0100, Ben Dooks wrote:
> On 12/06/12 15:41, Rob Herring wrote:
>> From: Rob Herring<rob.herring at calxeda.com>
>> Add clock binding information for primecell peripherals. For most, a
>> clock input name of "apb_pclk" is required. Any primecell peripherals
>> which are different will need to be documented separately.
> Really they should just use NULL as their bus clock name,
> and the drivers be fixed for this.


Do you know what you're talking about, because I don't think you do.  You
seem to be making random spontaneous comments without really knowing the
background behind things.

In this case, apb_pclk is the APB PCLK signal, as opposed to any
_functional_ clock required by the primecell peripheral.  To use NULL
there when the primecell probably _also_ takes a functional clock is
absurd, and to go on to suggest that the bus layer should be using NULL
here is insane.

We really do not want the bus layer picking up on the functional clock
"by accident" because someone forgot to give it.  Using a non-NULL name
here is entirely appropriate.

Please take some time to research the things that you're commenting on
before commenting on them, to avoid leading people down inappropriate

Thank you.

More information about the linux-arm-kernel mailing list