[PATCH v6 12/14] usb: chipidea: permit driver bindings pass phy pointer

Richard Zhao richard.zhao at freescale.com
Thu Jun 21 04:38:26 EDT 2012


On Thu, Jun 21, 2012 at 09:18:22AM +0200, Marc Kleine-Budde wrote:
> On 06/21/2012 08:41 AM, Richard Zhao wrote:
> > Sometimes, the driver bindings may know what phy they use.
> > For example, when using device tree, the usb controller may have a
> > phandler pointing to usb phy.
> > 
> > Signed-off-by: Richard Zhao <richard.zhao at freescale.com>
> > Reviewed-by: Marek Vasut <marex at denx.de>
> > Acked-by: Felipe Balbi <balbi at ti.com>
> > Tested-by: Subodh Nijsure <snijsure at grid-net.com>
> 
> [...]
> 
> > --- a/drivers/usb/chipidea/udc.c
> > +++ b/drivers/usb/chipidea/udc.c
> > @@ -1684,7 +1684,8 @@ static int udc_start(struct ci13xxx *ci)
> >  
> >  	ci->gadget.ep0 = &ci->ep0in->ep;
> >  
> > -	ci->transceiver = usb_get_transceiver();
> > +	if (ci->global_phy) {
>                            ^^^
> 
> This doesn't compile, closing curly brackets are missing.
> 
Nice catch. 

Thanks
Richard




More information about the linux-arm-kernel mailing list