[PATCH v2] pinctrl: pinctrl-imx: fix map setting problem if NO_PAD_CTL is set

Linus Walleij linus.walleij at linaro.org
Wed Jun 20 15:25:35 EDT 2012


On Wed, Jun 20, 2012 at 12:13 PM, Hui Wang <jason77.wang at gmail.com> wrote:

> new_map is allocated according to map_num instead of grp->npins,
> if a pin or some pins of a group has NO_PAD_CTL property, the map_num
> and the grp->npin are different definitely.
>
> When we set mapping information to the new_map[], we should skip those
> pins with NO_PAD_CTL from index, otherwise it is possible the driver
> will aceesss to a unallocated region.
>
> Cc: Dong Aisheng <dong.aisheng at linaro.org>
> Cc: Linus Walleij <linus.walleij at linaro.org>
> Cc: Shawn Guo <shawn.guo at linaro.org>
> Signed-off-by: Hui Wang <jason77.wang at gmail.com>
> ---
> In the v2, according to dong.aisheng's suggestion, change to use j as index.

OK applied this v2 version. Is this a serious bug fix that is causing
regressions right now and needs to go into the -rc:s for v3.5 or can it wait
for v3.6?

Thanks,
Linus Walleij



More information about the linux-arm-kernel mailing list