[PATCH v2] PINCTRL: SiRF: add GPIO and GPIO irq support in CSR SiRFprimaII

[Barry Song]

Hi Linus,

2012/6/20 Linus Walleij <linus.walleij at linaro.org>:
> On Tue, Jun 19, 2012 at 9:16 AM, Barry Song <Barry.Song at csr.com> wrote:
>
>> In SiRFprimaII, Each GPIO pin can be configured as input or output
>> independently. If a GPIO is configured as input, it can also be
>> enabled as an interrupt source (either edge or level triggered).
>>
>> These pins must be either MUXed as GPIO or other function pads.
>>
>> Signed-off-by: Yuping Luo <Yuping.Luo at csr.com>
>> Signed-off-by: Barry Song <Baohua.Song at csr.com>
>
> This is looking great!
> Acked-by: Linus Walleij <linus.walleij at linaro.org>
>
> I assume you will merge this through the ARM SoC tree and the
> PrimaII branch? Tell me if you need it to be merged through the
> pinctrl tree.

Thanks. i'll handle it in primaII tree.

>
>> +/* Pull up/down values */
>> +enum sirfsoc_gpio_pull {
>> +       SIRFSOC_GPIO_PULL_NONE,
>> +       SIRFSOC_GPIO_PULL_UP,
>> +       SIRFSOC_GPIO_PULL_DOWN,
>> +};
>
> As noted you can use pinconf-generic and friends, but it's definately
> not a requirement. You can also do that as a refactoring on top of this
> patch if you want to.
>
> Yours,
> Linus Walleij
>

-barry