[PATCH] pinctrl: pinctrl-mxs: mxs_dt_node_to_map: fix typo free -> kfree

devendra.aaru devendra.aaru at gmail.com
Mon Jun 18 10:01:50 EDT 2012


Hi Marc,

On Mon, Jun 18, 2012 at 7:11 PM, Marc Kleine-Budde <mkl at pengutronix.de> wrote:
> In commit:
> 0bf7481 pinctrl: pinctrl-mxs: Take care of frees if the kzalloc fails
> the memory allocated with kzalloc is tried to free with "free", which
> is not defined in the kernel, use "kfree" instead.
>
> Cc: Devendra Naga <devendra.aaru at gmail.com>
> Signed-off-by: Marc Kleine-Budde <mkl at pengutronix.de>
> ---
> This problem exists with current linus/master (v3.5-rc3-81-gd2a1a6b).
> I haven't chekced if it has been fixed somewhere upstream.
>
> regards, Marc
>
>  drivers/pinctrl/pinctrl-mxs.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/pinctrl-mxs.c b/drivers/pinctrl/pinctrl-mxs.c
> index afb50ee..4ba4636 100644
> --- a/drivers/pinctrl/pinctrl-mxs.c
> +++ b/drivers/pinctrl/pinctrl-mxs.c
> @@ -137,7 +137,7 @@ static int mxs_dt_node_to_map(struct pinctrl_dev *pctldev,
>
>  free_group:
>        if (!purecfg)
> -               free(group);
> +               kfree(group);
>  free:
>        kfree(new_map);
>        return ret;
> --
> 1.7.10
>

This change is already accepted by Linus walleij. (see for-next of his
tree for the fix).

Thanks,
Devendra.



More information about the linux-arm-kernel mailing list