[PATCH] ARM: mx23: Add initial support for olinuxino board

Fabio Estevam festevam at gmail.com
Sun Jun 17 08:59:18 EDT 2012


On Sun, Jun 17, 2012 at 9:41 AM, Fabio Estevam <festevam at gmail.com> wrote:
> On Sun, Jun 17, 2012 at 8:14 AM, Marek Vasut <marex at denx.de> wrote:
>
>>>  static const char *imx23_dt_compat[] __initdata = {
>>>       "fsl,imx23-evk",
>>> +     "fsl,imx23-olinuxino",
>>
>> Is this addition needed?
>
> Actually it is not required. Board boots just fine without it.
>
> I have just kept this for compatibilty with other i.MX boards boards
> added to dt.
>
> I followed the same approach from imx6q_dt_compat and imx53_dt_compat.

I would prefer to do something like that instead:

static const char *<soc>_dt_compat[] __initdata = {
	"fsl,<soc>",
	NULL,
}

,this way we do not have to patch a C file when adding a new board file.

Shawn, what do you think?

Should I drop the  "fsl,imx23-olinuxino",

addition of this patch and then work on another patch that keeps the

static const char *<soc>_dt_compat[] __initdata = {
	"fsl,<soc>",
	NULL,
}

approach?



More information about the linux-arm-kernel mailing list