[PATCH 07/16] dma: ipu: remove the use of ipu_platform_data

Shawn Guo shawn.guo at linaro.org
Fri Jun 15 23:01:08 EDT 2012


On Fri, Jun 15, 2012 at 05:37:14PM +0800, Dong Aisheng wrote:
> On Thu, Jun 14, 2012 at 01:59:38PM +0800, Shawn Guo wrote:
> .......
> > @@ -354,10 +355,12 @@ static struct irq_chip ipu_irq_chip = {
> >  /* Install the IRQ handler */
> >  int __init ipu_irq_attach_irq(struct ipu *ipu, struct platform_device *dev)
> >  {
> > -	struct ipu_platform_data *pdata = dev->dev.platform_data;
> > -	unsigned int irq, irq_base, i;
> > +	unsigned int irq, i;
> > +	int irq_base = irq_alloc_descs(-1, 0, CONFIG_MX3_IPU_IRQS,
> > +				       numa_node_id());
> >  
> > -	irq_base = pdata->irq_base;
> > +	if (irq_base < 0)
> > +		return irq_base;
> >  
> Need not add irqdomain for this irq range?
> Can we still service this irq properly without irqdomain mapping?
> 
Yes, I think it should still work, because the driver has the mapping
management on its own,  though someday we need to replace its own
mapping with irqdomain anyway when we move the driver to device tree.

-- 
Regards,
Shawn




More information about the linux-arm-kernel mailing list