[PATCH] kprobes: only test 'sub pc, pc, #1b-2b+8-2' on ARMv6

[Tixy]

On Fri, 2012-06-15 at 19:30 +0530, Rabin Vincent wrote:
> On Fri, Jun 15, 2012 at 7:06 PM, Tixy <tixy at yxit.co.uk> wrote:
> >> How about the following check instead?  At least one other place uses
> >> it.
> >
> > Can't you point out the other place which uses it, I couldn't find it.
> 
> arch/arm/kernel/entry-armv.S:445
> #if CONFIG_ARM_THUMB && __LINUX_ARM_ARCH__ >= 6 && CONFIG_CPU_V7

Yes, that's going to need looking at too when V8 arrives.

> > The proposed patch below would work, but feels slightly off as it
> > assumes that no one will build a kernel to support V6 and V8, but
> > without V7. That does seem highly unlikely though, so I personally
> > wouldn't object to the patch.
> 
> I've no preference either way, so if a deletion of the test case would get your
> acked-by instead of just a non-objection, I'll do that.

Actually, the kprobes implementation and test code will need looking at
again when V8 hits mainline, so lets not worry about it for the moment.
So, in that case, I agree with your revised patch which tests for not
CONFIG_CPU_V7 and you have:

Acked-by: Jon Medhurst <tixy at yxit.co.uk>

Thanks for looking at kprobes and contributing fixes.

As Russell King is the official maintainer of this code, can you add
your patches to his patch system?

Thanks again.

-- 
Tixy