[PATCH v3 4/4] memory: emif: add device tree support to emif driver

Greg Kroah-Hartman gregkh at linuxfoundation.org
Thu Jun 14 11:48:20 EDT 2012


On Thu, Jun 14, 2012 at 03:59:24PM +0530, Santosh Shilimkar wrote:
> From: Aneesh V <aneesh at ti.com>
> 
> Device tree support for the EMIF driver.
> 
> Reviewed-by: Benoit Cousson <b-cousson at ti.com>
> Reviewed-by: Grant Likely <grant.likely at secretlab.ca>
> Tested-by: Lokesh Vutla <lokeshvutla at ti.com>
> Signed-off-by: Aneesh V <aneesh at ti.com>
> [santosh.shilimkar at ti.com: Rebased against 3.5-rc]
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar at ti.com>
> Cc: Greg Kroah-Hartman <gregkh at linuxfoundation.org>

Am I the memory maintainer now taking these patches?

> @@ -1267,7 +1534,13 @@ static int __init_or_module emif_probe(struct platform_device *pdev)
>  	struct resource		*res;
>  	int			irq;
>  
> -	emif = get_device_details(pdev);
> +#if defined(CONFIG_OF)
> +	if (pdev->dev.of_node)
> +		emif = of_get_device_details(pdev->dev.of_node, &pdev->dev);
> +	else
> +#endif
> +		emif = get_device_details(pdev);
> +

Can't you do this without the #ifdef?

thanks,

greg k-h



More information about the linux-arm-kernel mailing list