[PATCH v5 02/14] ARM: OMAP2+: gpmc: Adapt to HWMOD

Mohammed, Afzal afzal at ti.com
Thu Jun 14 09:32:58 EDT 2012


Hi Jon,

On Thu, Jun 14, 2012 at 18:52:55, Hunter, Jon wrote:
> On 06/14/2012 02:03 AM, Mohammed, Afzal wrote:
> > On Wed, Jun 13, 2012 at 20:21:50, Hunter, Jon wrote:

> >> If the clk handle for the gpmc is passed to the gpmc driver, then there
> >> is no reason why the driver cannot do this.
> > 
> > I believe passing clk details through platform data is an abuse of
> > clock framework.
> 
> Why? You currently have a global variable storing the clock handle. It
> can be quite common for drivers to know the clock frequencies of their
> functional clocks. How else can drivers calculate timings?


Please see Russell King's comments,

[1] http://permalink.gmane.org/gmane.linux.ports.ppc.embedded/27634
[2] http://www.mail-archive.com/linux-samsung-soc@vger.kernel.org/msg05365.html

Regards
Afzal




More information about the linux-arm-kernel mailing list