[PATCH v5 05/14] ARM: OMAP2+: gpmc: resource creation helpers

Mohammed, Afzal afzal at ti.com
Thu Jun 14 04:44:01 EDT 2012


Hi Jon,

On Wed, Jun 13, 2012 at 21:03:44, Hunter, Jon wrote:
> On 06/13/2012 12:29 AM, Mohammed, Afzal wrote:

> > Irq & memory resource creation functions returns number of resources,
> > if memory function only is modified, that will cause loss of uniformity
> > w.r.t irq function, even though both does similar things.
> 
> Ok, I see what you mean but from a readability standpoint it looked odd.
> The other function is returning "n" where as this is just returning 1 on
> success but it is not clear that this actually means 1 resource.

Ok, I will add comments to make it clear

Regards
Afzal



More information about the linux-arm-kernel mailing list