[PATCH 01/16] ARM: imx: eliminate macro IMX_GPIO_TO_IRQ()

Dong Aisheng aisheng.dong at freescale.com
Thu Jun 14 04:04:55 EDT 2012


On Thu, Jun 14, 2012 at 03:39:58PM +0800, Shawn Guo wrote:
> On Thu, Jun 14, 2012 at 03:31:46PM +0800, Dong Aisheng wrote:
> > > -		.irq		= IMX_GPIO_TO_IRQ(TSC2007_IRQGPIO),
> > > +		/* irq number is run-time assigned */
> > Maybe this line is not need.
> > 
> Documentation never harms.
> 
Hmm, you may see in the patch, this comment is added in every places
where need change even in the same file, so totally we added a lot
duplicated lines.

IMHO for this common sense bits, we may not have to document it.
User can refer to common document or code.

Regards
Dong Aisheng




More information about the linux-arm-kernel mailing list