[PATCH v5 04/14] ARM: OMAP2+: gpmc: minimal driver support

[Jon Hunter]

On 06/13/2012 08:40 AM, Tony Lindgren wrote:
> * Mohammed, Afzal <afzal at ti.com> [120613 06:16]:
>> Hi Tony,
>>
>> On Wed, Jun 13, 2012 at 17:37:17, Tony Lindgren wrote:
>>> * Jon Hunter <jon-hunter at ti.com> [120612 11:01]:
>>>>
>>>> On 06/12/2012 02:16 AM, Mohammed, Afzal wrote:
>>
>>>>> Does having minor revision add any value ?, at least as of now,
>>>>> I do not see any.
>>>>
>>>> May be not but it does not hurt either.
>>>
>>> Yeah might as well show the full revision.
>>
>> We are already showing full version, but only storing major, it seems you
>> want to store minor version along with major version in the same variable,
>> right ?
> 
> Ah OK, yeah might as well just store the minor version.

Actually, you really need the major version. However, IMO if you are
going to store it, then store the whole thing, you have allocated
32-bits and the major and minor combined are 8-bits.

Jon