[PATCH 5/9] ARM: OMAP2+: gpmc-smc91x: Adapt to use gpmc driver

Tony Lindgren tony at atomide.com
Wed Jun 13 09:43:24 EDT 2012

* Mohammed, Afzal <afzal at ti.com> [120613 06:43]:
> Hi Tony,
> On Wed, Jun 13, 2012 at 17:59:50, Tony Lindgren wrote:
> > Here too we just need to care about the mainline kernel users
> > and convert them to use the new interface. No need to keep
> > gpmc_cs_set_timings around. The same applies for other similar
> > patches.
> Not sure whether I follow you here.
> Do you mean for all the gpmc-* helpers existing initialization
> needs to be modified to use the new interface, the previous version
> was doing so. But then that will cause all boards using the same
> gpmc-* helper to be converted at once (tusb6010 is not an issue as
> only one board uses it), then the problem will be that there would
> be a few commits where gpmc may not work properly.
> And for a particular board, either it has to use old interface
> or either the new interface, it cannot use both.
> Consider the case of this one, smc91x, all sdp boards use it,
> that requires nand, onenand, nor gpmc-* helpers to be converted
> before board migration for say 3430sdp board, that would mean
> that 2430sdp board would be broken w.r.t gpmc at that commit as
> board modifications are not yet done for 2430. That in turn means
> all the boards using nand, onenand would be broken at that point.

What I mean is keep the old interface in gpmc.c, then convert
users one at a time to the new interface, and remove the old
interface code from the users. But yeah you're right, it may
not be immediately doable for the smc91x case before we dump
out the register values. But at least tusb6010 should be able
to just convert to use the new interface and drop the old code.


More information about the linux-arm-kernel mailing list