[PATCH 2/3] clk: add ICST307 driver

Linus Walleij linus.walleij at linaro.org
Wed Jun 13 04:38:26 EDT 2012

On Wed, Jun 13, 2012 at 1:06 AM, Mike Turquette <mturquette at ti.com> wrote:
> On 20120611-17:39, Linus Walleij wrote:

>> +obj-$(CONFIG_CLK_ICST)               += clk-icst.o
> Is there a better place to put this than the top-level directory?

I can put it alone in a subdirectory if you want to... It is used only
by the ARM reference designs AFAICT, shall I put these Integrator
things into clk/versatile as we use the "versatile" name to refer to all
ARM reference designs (i.e. arch/arm/plat-versatile).

>> +struct clk * __init icst_clk_init(struct device *dev, const struct clk_icst_desc *desc)
> Nitpick: icst_clk_init should be renamed icst_clk_register to more
> closely resemble other clock registration functions which allocate
> memory dynamically.

I'll fix!

Linus Walleij

More information about the linux-arm-kernel mailing list