[PATCH 14/14] ARM: ux500: Move rtc-pl031 registration to Device Tree when enabled
lee.jones at linaro.org
Tue Jun 12 10:44:51 EDT 2012
On 12/06/12 15:32, Linus Walleij wrote:
> On Tue, Jun 12, 2012 at 10:03 AM, Lee Jones<lee.jones at linaro.org> wrote:
>> On 11/06/12 22:43, Linus Walleij wrote:
>>> Oh this is a bug fix really, well it's in the device tree so nevermind.
>> It is? How so?
> That the device tree was declaring a compatible node for something
> that never existed (stericsson,db8500-rtc) while the real node is
> "arm,rtc-pl031", "arm,primecell".
> Without this fix 3.4 will not have an PL031 RTC I guess?
Think of the old entry as a dummy one, a stub if you will. Quite a few
of the entries were initially loaded into the Device Tree as a best
effort first attempt and had to be changed at a later date. This is no
different. I see this as an enablement patch rather than a bug-fix. In
fact, there would have been a bug if this worked when it was initially
written, as the driver would have probed twice on a DT boot. Once by DT
and once by platform code.
Linaro ST-Ericsson Landing Team Lead
M: +44 77 88 633 515
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
More information about the linux-arm-kernel