[RFC PATCH] MTD: nand: add return value for write_page() function in structure of nand_ecc_ctrl.

Artem Bityutskiy dedekind1 at gmail.com
Tue Jun 12 06:49:36 EDT 2012


On Fri, 2012-06-08 at 19:10 +0800, Josh Wu wrote:
>  /**
> + * nand_write_page_none - [INTERN] raw page writen function with return value
> + * @mtd: mtd info structure
> + * @chip: nand chip info structure
> + * @buf: data buffer
> + * @oob_required: must write chip->oob_poi to OOB
> + */
> +static inline int nand_write_page_none(struct mtd_info *mtd,
> +                               struct nand_chip *chip,
> +                               const uint8_t *buf, int oob_required)
> +{
> +       nand_write_page_raw(mtd, chip, buf, oob_required);
> +
> +       return 0;
> +} 

Thanks!

Would you please also make the wrtite_page_raw call-back return an error
code - it is just strange to change '->write_page' and avoid changing
'->write_page_raw'...

P.S. Not sure we still want these baroque header comments, but this is
just a side note and separate issue.

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120612/e17906fc/attachment.sig>


More information about the linux-arm-kernel mailing list