[PATCH 1/1] ARM: dma-mapping: Add missing static storage class specifier
Marek Szyprowski
m.szyprowski at samsung.com
Mon Jun 11 08:27:34 EDT 2012
Hi,
On Monday, June 04, 2012 12:18 PM Sachin Kamat wrote:
> Fixes the following sparse warnings:
> arch/arm/mm/dma-mapping.c:231:15: warning: symbol 'consistent_base' was not declared. Should
> it be static?
> arch/arm/mm/dma-mapping.c:326:8: warning: symbol 'coherent_pool_size' was not declared. Should
> it be static?
>
> Signed-off-by: Sachin Kamat <sachin.kamat at linaro.org>
Thanks for the patch. I've applied it to my dma-mapping fixes branch.
> ---
> arch/arm/mm/dma-mapping.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
> index ea6b431..788acb7 100644
> --- a/arch/arm/mm/dma-mapping.c
> +++ b/arch/arm/mm/dma-mapping.c
> @@ -228,7 +228,7 @@ static pte_t **consistent_pte;
>
> #define DEFAULT_CONSISTENT_DMA_SIZE SZ_2M
>
> -unsigned long consistent_base = CONSISTENT_END - DEFAULT_CONSISTENT_DMA_SIZE;
> +static unsigned long consistent_base = CONSISTENT_END - DEFAULT_CONSISTENT_DMA_SIZE;
>
> void __init init_consistent_dma_size(unsigned long size)
> {
> @@ -323,7 +323,7 @@ static struct arm_vmregion_head coherent_head = {
> .vm_list = LIST_HEAD_INIT(coherent_head.vm_list),
> };
>
> -size_t coherent_pool_size = DEFAULT_CONSISTENT_DMA_SIZE / 8;
> +static size_t coherent_pool_size = DEFAULT_CONSISTENT_DMA_SIZE / 8;
>
> static int __init early_coherent_pool(char *p)
> {
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
More information about the linux-arm-kernel
mailing list