Freescale fec.c driver breakage

Sascha Hauer s.hauer at pengutronix.de
Tue Jun 5 09:42:55 EDT 2012


On Tue, Jun 05, 2012 at 11:24:29PM +1000, Greg Ungerer wrote:
> On 06/05/2012 10:48 PM, Sascha Hauer wrote:
> >On Tue, Jun 05, 2012 at 10:17:02PM +1000, Greg Ungerer wrote:
> >>
> >>>clkdev
> >>>provides an abstraction which can map these onto the platform, even if
> >>>you don't use the generic clk API clkdev is still very useful and will
> >>>help with a lot of these issues.
> >>
> >>In this specific case I don't know what the ipg or ahb clocks are on iMX
> >>(Sascha?), but there is nothing equivalent to them in the FEC cores used
> >>on existing ColdFire CPUs. They seem to be platform specific (iMX) more
> >>than FEC driver specific.
> >
> >I am sure the Coldfire FEC also needs clocks to work. Just like Mark
> >said, they may be not software controllable. The names 'ipg' and 'ahb'
> >may be i.MX specific though.
> 
> Well, yeah, of course there are clocks involved. But you pretty much
> hit the point here. 'ipg' and 'ahb' here are platform specific.

Are there any FEC specific names? If yes, we could use these instead,
otherwise if we have to make up names ourselves I think 'ipg' and 'ahb'
are fine.

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



More information about the linux-arm-kernel mailing list