[RFC 08/34] dmaengine: PL08x: clean up get_signal/put_signal

Russell King - ARM Linux linux at arm.linux.org.uk
Fri Jun 1 06:48:36 EDT 2012


On Thu, May 31, 2012 at 08:53:33AM +0800, Linus Walleij wrote:
> On Tue, May 29, 2012 at 5:37 PM, Russell King
> <rmk+kernel at arm.linux.org.uk> wrote:
> 
> > Try to avoid dereferencing the DMA engine's channel struct in these
> > platform helpers; instead, pass a pointer to the channel data into
> > get_signal(), and the returned signal number to put_signal().
> >
> > Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
> 
> There is an in-tree user of this interface now, so it needs to be fixed
> as part of this patch:
> ]$ grep -r pl080_get_signal .
> ./mach-spear6xx/spear6xx.c:	.get_signal = pl080_get_signal,
> ./plat-spear/include/plat/pl080.h:int pl080_get_signal(struct
> pl08x_dma_chan *ch);
> ./plat-spear/pl080.c:int pl080_get_signal(struct pl08x_dma_chan *ch)
> ./mach-spear3xx/spear3xx.c:	.get_signal = pl080_get_signal,

I can't do that at the moment because that's come in during this merge
window and these patches are based on v3.4 at the moment.  In other
words, for the purposes of this series, the above simply does not exist.



More information about the linux-arm-kernel mailing list