[PATCH 1/2 v4] ARM: OMAP2+: omap_hwmod: Add api to enable/disable module level wakeup events

Menon, Nishanth nm at ti.com
Fri Jun 1 05:29:44 EDT 2012


On Wed, Apr 25, 2012 at 2:17 AM, Govindraj.R <govindraj.raja at ti.com> wrote:
[...]
> --- a/arch/arm/mach-omap2/prm2xxx_3xxx.h
> +++ b/arch/arm/mach-omap2/prm2xxx_3xxx.h
> @@ -289,6 +289,13 @@ static inline int omap2_prm_deassert_hardreset(s16 prm_mod, u8 rst_shift,
>                "not suppose to be used on omap4\n");
>        return 0;
>  }
> +static inline void omap2_prm_enable_prcm_module_wakeup(s16 prcm_mod,
> +               u8 prm_reg_id, u8 prm_reg_shift, bool set_wake)
> +{
> +       WARN(1, "prm: omap2xxx/omap3xxx specific function and "
> +               "not suppose to be used on omap4\n");
> +       return 0;
^^^^^ minor comment - we should not return a value in a function returning void

[...]
Regards,
Nishanth Menon



More information about the linux-arm-kernel mailing list