[PATCH 0/2] gpio/omap: few code realignment and update of missing code

Tarun Kanti DebBarma tarun.kanti at ti.com
Wed Jul 11 05:13:13 EDT 2012


This is in reponse to comments provided to [gpio/omap: add clk_prepare
and clk_unprepare] and is available here for reference:
http://lists.infradead.org/pipermail/linux-arm-kernel/2012-June/105762.html

Patch-1 moves the debounce clock handle initialization from gpio_debounce()
to omap_gpio_mod_init(). Since this is a one time initialization it makes
sense to keep it here. Though proposal was to keep in omap_gpio_chip_init()
I found more appropriate to keep in omap_gpio_mod_init() because it is more
related to bank specific initialization.

Patch-2 adds *.remove* callback which is missing in current implementation.
Along with other cleanup operations this function is used for releasing the
clock handle and of course calling clk_unprepare().

Reference:
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git
Commit: bd0a521e88aa7a06ae7aabaed7ae196ed4ad867a (Linux 3.5-rc6)

Tested on: OMAP3630/ZOOM3, BLAZE

Tarun Kanti DebBarma (2):
  gpio/omap: move bank->dbck initialization to omap_gpio_mod_init()
  gpio/omap: add *remove* callback in platform_driver

 drivers/gpio/gpio-omap.c |   40 ++++++++++++++++++++++++++++++++++------
 1 files changed, 34 insertions(+), 6 deletions(-)




More information about the linux-arm-kernel mailing list