[PATCH v3 00/10] Add tegra30 support for secondary cores
Peter De Schrijver
pdeschrijver at nvidia.com
Wed Feb 29 10:42:29 EST 2012
On Wed, Feb 15, 2012 at 10:27:43PM +0100, Stephen Warren wrote:
> Peter De Schrijver wrote at Thursday, February 09, 2012 4:48 PM:
> > This patchset introduces support for secondary cores on tegra30. It also
> > introduces some functions for the flowcontroller and adds basic support for
> > tegra30 powerdomains.
> The code looks fine to me. I do notice the following when running
> "shutdown -h now":
> [ 27.762124] SMP: failed to stop secondary CPUs
> So, this patch series makes the secondary cores boot OK, but not shut
> down it appears. Is that expected? It's probably something we can fix
> with a following on patch rather than re-spinning this series though?
I spent some more time looking at this. It appears that nr_online_cpus isn't
always updated properly. I added an extra pr_warn() when the failure happens
and I got:
[ 22.369815] Restarting system.
[ 23.506792] SMP: failed to stop secondary CPUs
[ 23.511535] running on CPU: 3, still online: 2, mask: 8
I also did some function tracing and all CPUs besides the one initiating the
halt reach platform_cpu_kill() about 50us after sending the IPIs to stop them.
The set_cpu_online() call in ipi_cpu_stop() should update nr_online_cpus, but
somehow this doesn't always happen. Any insight on what might be going on?
Instrumentation patch attached.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 1189 bytes
Desc: not available
More information about the linux-arm-kernel