[PATCH 7/8] ARM: OMAP: Remove plat/io.h by moving it into mach/io.h
Tony Lindgren
tony at atomide.com
Tue Feb 28 20:49:08 EST 2012
* Tony Lindgren <tony at atomide.com> [120228 17:15]:
> * Rob Herring <robherring2 at gmail.com> [120226 19:15]:
> > On 02/24/2012 12:22 PM, Tony Lindgren wrote:
> > > * Tony Lindgren <tony at atomide.com> [120223 15:36]:
> > >> * Rob Herring <robherring2 at gmail.com> [120221 17:53]:
> > >>> On 02/21/2012 05:40 PM, Tony Lindgren wrote:
> > >>>> +
> > >>>> +/*
> > >>>> + * NOTE: Please use ioremap + __raw_read/write where possible instead of these
> > >>>> + */
> > >>>> +
> > >>>> +extern u8 omap_readb(u32 pa);
> > >>>> +extern u16 omap_readw(u32 pa);
> > >>>> +extern u32 omap_readl(u32 pa);
> > >>>> +extern void omap_writeb(u8 v, u32 pa);
> > >>>> +extern void omap_writew(u16 v, u32 pa);
> > >>>> +extern void omap_writel(u32 v, u32 pa);
> > >>>
> > >>> These can't be moved to common.h like omap2?
> > >>
> > >> Not for omap1 currently because a bunch of legacy drivers are
> > >> using them :(
> > >
> > > Looks like we can have them in mach-omap1/include/mach/hardware.h.
> > >
> > > Eventually the SoC specific hardware.h files could be renamed to
> > > just something like omap1.h, omap2plus.h and so. And then they
> > > could be included in the common hardware.h.
> > >
> > > Updated patch below, now io.h for both omap1 and omap2+ are
> > > minimized, and turns out only minimal driver changes were needed.
> > >
> >
> > Looks good to me. Do you have a branch for this that I can base on?
>
> Yes it's now in iomap branch that merged into my cleanup branch that
> I'll ask Arnd and Olof to pull tomorrow.
>
> So take your pick out of the following two:
>
> 1. iomap branch based on v3.3-rc4 that you probably want to use
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap iomap
Correction: #1 above is based on v3.3-rc3, not -rc4.
> 2. cleanup branch based on RMK's commit 61b80086a525c8a6081257ae40da5dee2bcaee16
> (Merge branch 'entry-macro-cleanup' of git://sources.calxeda.com/kernel/linux into for-armsoc)
>
> git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap cleanup
Regards,
Tony
More information about the linux-arm-kernel
mailing list