[PATCH 4/6] ASoC: fsl: create fsl_utils to accommodate the common functions
Timur Tabi
timur at freescale.com
Tue Feb 28 11:51:09 EST 2012
Shawn Guo wrote:
> +EXPORT_SYMBOL_GPL(fsl_asoc_get_codec_dev_name);
Please use EXPORT_SYMBOL() instead of EXPORT_SYMBOL_GPL(). Freescale does
not want to impose license restrictions on its customers.
Also, I think there's a bug in this function that I never got around to
fixing. I think you need to call put_device() somewhere.
of_find_i2c_device_by_node() calls bus_find_device(), which calls
get_device(), which increments the reference count.
--
Timur Tabi
Linux kernel developer at Freescale
More information about the linux-arm-kernel
mailing list