[PATCH] pxa/hx4700: Fix basic suspend/resume

[Haojian Zhuang]

On Mon, Feb 27, 2012 at 5:04 PM, Russell King - ARM Linux
<linux at arm.linux.org.uk> wrote:
> On Sun, Feb 26, 2012 at 11:54:13AM +0100, Philipp Zabel wrote:
>> Am Mittwoch, den 11.05.2011, 19:49 +0000 schrieb Paul Parsons:
>> > Basic suspend/resume is fixed by ensuring that the PGSR registers are set correctly before sleep mode is entered. In particular four of the active low resets need to be driven high while in sleep mode, otherwise the unit resets itself instead of suspending. Another problem was that the PCFR_GPROD bit is apparently set by the HTC bootloader; this caused GPIO reset (i.e. the reset button) to fail immediately after returning from sleep mode.
>> >
>> > Driver-specific bugs still remain. In particular the mmc driver does not resume properly after returning from sleep mode, thus preventing sleep mode from being entered a second time.
>> >
>> > Signed-off-by: Paul Parsons <lost.distance at yahoo.com>
>> > ---
>> > --- clean-2.6.39-rc7/arch/arm/mach-pxa/hx4700.c     2011-05-11 00:54:10.787247169 +0100
>> > +++ linux-2.6.39-rc7/arch/arm/mach-pxa/hx4700.c     2011-05-11 20:21:54.026109594 +0100
>> > @@ -120,7 +120,11 @@ static unsigned long hx4700_pin_config[]
>> >     GPIO19_SSP2_SCLK,
>> >     GPIO86_SSP2_RXD,
>> >     GPIO87_SSP2_TXD,
>> > -   GPIO88_GPIO,
>> > +   MFP_CFG_OUT(GPIO88, AF0, KEEP_OUTPUT),  /* TSC2046_CS */
>>
>> What you want here is to keep the SPI chip select deasserted (high)
>> during suspend, so I think that should be DRIVE_HIGH instead.
>
> And I don't think we allowed folk to use MFP_CFG_xxx() macros in their
> board support code.  Is there something wrong with:
>
>        GPIO88_GPIO | MFP_LPM_KEEP_OUTPUT
>

Yes, it should be MFPR_LPM_DRIVE_HIGH or MFPR_LPM_PULL_HIGH.
Thanks for your reminder.

Paul,

Could you help to format the patch again?

Best Regards
Haojian