[PATCH] ARM: integrator: convert to sparse irqs

Rob Herring robherring2 at gmail.com
Sun Feb 26 22:42:13 EST 2012


On 02/26/2012 03:45 AM, Linus Walleij wrote:
> On Fri, Feb 24, 2012 at 8:15 PM, Jean-Christophe PLAGNIOL-VILLARD
> <plagnioj at jcrosoft.com> wrote:
>> On 18:32 Fri 24 Feb     , Linus Walleij wrote:
> 
>>> -#define NR_IRQS                         47
>>> +#define NR_IRQS_INTEGRATOR_AP                34
>>> +#define NR_IRQS_INTEGRATOR_CP                47
>>
>> why do you need to specified both?
> 
> They are two totally different machines and should never have had that
> common roof of NR_IRQS = max(AP,CP), it's just not elegant.
> 
> Maybe I'm a bit pedantic but I want to set the .nr_irqs for each machine so that
> it corresponds exactly to what it actually has, instead of using a roof value.
> I think it improves readability and understanding.
> 

Really, you want to get rid of the value altogether. Each irq_chip
should allocate its irq_descs and then you don't need to set .nr_irqs.

Rob

> Yours
> Linus Walleij



More information about the linux-arm-kernel mailing list