[PATCH] pxa/hx4700: Avoid unbalanced irq wakeup enables/disables

[Haojian Zhuang]

On Sun, Feb 26, 2012 at 6:48 PM, Philipp Zabel <philipp.zabel at gmail.com> wrote:
> Am Donnerstag, den 05.05.2011, 01:10 +0000 schrieb Paul Parsons:
>> Resuming a suspended hx4700 results in Unbalanced IRQ warnings:
>>
>> WARNING: at kernel/irq/manage.c:507 irq_set_irq_wake+0xe0/0xec()
>> Unbalanced IRQ 246 wake disable
>> ..
>>
>> Likewise for IRQ 241 and IRQ 243. The 3 ASIC3 GPIO buttons - RECORD/CALENDAR/HOME - each fail in a call to enable_irq_wake() in gpio_keys_suspend() because of an absent irq_set_wake() handler in the asic3_gpio_irq_chip structure. Matching calls to disable_irq_wake() in gpio_keys_resume() then print the warnings. Since we should never need to resume via the 3 ASIC3 GPIO buttons, nor 2 of the 3 builtin GPIO buttons - MAIL/CONTACTS, the simplest remedy for the warnings is to enable irq wakeup on the POWER button only.
>>
>> Signed-off-by: Paul Parsons <lost.distance at yahoo.com>
>> ---
>> --- clean-2.6.39-rc6/arch/arm/mach-pxa/hx4700.c       2011-05-04 12:09:06.298511475 +0100
>> +++ linux-2.6.39-rc6/arch/arm/mach-pxa/hx4700.c       2011-05-05 00:07:57.034493981 +0100
>> @@ -191,7 +191,7 @@ static struct pxaficp_platform_data ficp
>>               .active_low = _active_low,              \
>>               .desc       = _desc,                    \
>>               .type       = EV_KEY,                   \
>> -             .wakeup     = 1,                        \
>> +             .wakeup     = KEY_##_code == KEY_POWER, \
>>       }
>>
>>  static struct gpio_keys_button gpio_keys_buttons[] = {
>>
>
> On my hx4700 iPAQ running Windows Mobile 5, gpio button wakeup is
> configurable under "Start -> Settings -> Personal -> Buttons -> Lock".
> There is a checkbox "Disable all buttons except power button" which
> enables/disables the keypad and ASIC3 GPIO buttons as wakeup sources.
>
> To achieve the same functionality on linux, we could split the power
> button and the other buttons into separate gpio_keys devices and let
> userspace disable the other buttons as wakeup sources via the device's
> pm_wakeup interface. For that we need
>
> Given that ASIC3 doesn't support irq_set_wake for now,
> Acked-By: Philipp Zabel <philipp.zabel at gmail.com>
>
It seems that this patch is only enable powerup key as wakeup source.
Other gpio keys could be configured as wakeup source in user space. So could
you help to figure out the interface of configuring gpio key as wakeup source
in user space?

Thanks
Haojian