[PATCH 3/3] ARM: PXA27x: Zipit Z2: disable wake on GPIO0

[Marek Vasut]

> On Sun, Feb 26, 2012 at 11:21:49PM +0100, Marek Vasut wrote:
> > > 2012/2/26 Russell King - ARM Linux <linux at arm.linux.org.uk>:
> > > > On Sun, Feb 26, 2012 at 06:11:17PM +0300, Vasily Khoruzhick wrote:
> > > >> 2012/2/26 Russell King - ARM Linux <linux at arm.linux.org.uk>:
> > > >> > On Sun, Feb 26, 2012 at 04:47:42PM +0300, Vasily Khoruzhick wrote:
> > > >> >> We don't want machine to wake up on AC state change
> > > >> > 
> > > >> > NAK.  Stop polluting the machine callback methods.  Use the right
> > > >> > one.
> > > >> 
> > > >> Ok, what's right one?
> > > >> 
> > > >        void                    (*fixup)(struct tag *, char **,
> > > >        
> > > >                                         struct meminfo *);
> > > >        
> > > >        void                    (*reserve)(void);/* reserve mem blocks
> > > >         */ void                    (*map_io)(void);/* IO mapping
> > > >        function  */ void                    (*init_early)(void);
> > > >        void                    (*init_irq)(void);
> > > >        struct sys_timer        *timer;         /* system tick timer  
> > > >         */ void                    (*init_machine)(void);
> > > > 
> > > > and chose a more appropriate one from that?  Maybe init_early() if it
> > > > has to be done early, or preferably the init_machine() if it can wait
> > > > until arch_initcall() time.
> > > > 
> > > > But stuffing it into fixup, reserve, map_io, init_irq or the timer
> > > > initialization is pure abuse of those callbacks.
> > > 
> > > Ok, thanks.
> > 
> > Or this should be patched in the bootloader too. Also, please dont
> 
> * introduce ad-hoc constants like "1 << 0", ever!
> 
> Fiddling with PWER should not be in the boot loader.  The kernel handles
> PWER just fine.

Right, good point