[PATCH v2] ARM: LPC32xx: Ethernet driver

[David Miller]

From: Baruch Siach <baruch at tkos.co.il>
Date: Sun, 26 Feb 2012 03:52:18 +0200

> Hi Roland,
> 
> On Sat, Feb 25, 2012 at 09:21:44PM +0100, Roland Stigge wrote:
>> This patch adds an ethernet driver for the LPC32xx ARM SoC.
>> 
>> Signed-off-by: Roland Stigge <stigge at antcom.de>
> 
> [snip]
> 
>> +static int __init ethaddr(char *s)
>> +{
>> +	int i;
>> +	unsigned int r[6];
>> +
>> +	sscanf(s, "%x:%x:%x:%x:%x:%x",
>> +			&r[0], &r[1], &r[2], &r[3], &r[4], &r[5]);
>> +	for (i = 0; i < 6; i++)
>> +		mac_address[i] = (u8)r[i];
>> +
>> +	return 1;
>> +}
>> +__setup("ethaddr=", ethaddr);
> 
> Please use a module_param() instead of a top level kernel parameter.

Actually, remove this entirely, we don't add module parameters
to force the ethernet address.  That should be done in userland
in some fashion.

We've had many discussions about this recently, and this is the
consistent policy we want to enforce in all drivers from now on.