[PATCH 4/4] ASoC: fsl: make fsl_ssi driver compilable on ARM/IMX
Timur Tabi
timur at freescale.com
Fri Feb 24 17:00:17 EST 2012
Russell King - ARM Linux wrote:
> BenH tells me that he'll accept patches which converts in_32be() to
> ioread32be(), as in_32be() is ancient PPC cruft that needs to die.
Where did he say this? in_be32() (and its variants) are used EVERYWHERE
in PowerPC code.
Also, keep in mind that on ARM, ioread32be() is probably wrong, because we
want to read the register as little-endian. The SSI audio controller is
little-endian on i.MX chips and big-endian on PowerPC chip. So we really
need a native-endian variant of ioread32be(). ioread32() is little-endian
on PowerPC, so we can't use that.
--
Timur Tabi
Linux kernel developer at Freescale
More information about the linux-arm-kernel
mailing list